fix: improve business logic in prompt editor and fix cursor bugs in Plan mode by nmggithub · Pull Request #867 · pingdotgg/t3code

nmggithub · 2026-03-10T23:53:29Z

What Changed

This makes four changes all related to the prompt editor (each in their own commit):

Removes a redundant function wrapper (least important)
Ensures that onChange doesn't fire in ComposerPromptEditor for prop-controlled changes (better behavior, I believe)
Fixes cursor position bug in Plan mode where the cursor isn't moved to the correct position as that code fires while the input is unfocused from a question navigation button press (Bug fix!)
Fixes another cursor position bug in Plan mode where the cursor would snap to the end on each keystroke (Bug fix! Resolves In the "Plan mode" text input cursor focus forced to the right #411, Resolves bug: text input on the GPT questions #909)

3 and 4 can be seen below. 1 and 2 are business logic changes that should (hopefully) not have any affect on the UI.

I could also add raising answer state to the composerDraftStore here, but I feel like that might be scope creep. It's all a bit intertwined, though, so separating them out is difficult.

Why

Each change has its own motivations:

The wrapper was redundant, and another callback was passed on its own (so I'm not breaking pattern).
This, I believe, is better behavior for a (semi-)controlled input here. Any controlling parent knows what values its passing in via props, so it has little need to get told of changes to those props via the onChange handler.
It appears the intended behavior is that the cursor is always put at the end when switching questions. This patches a case where that "didn't" happen (it still did end up at the end, but only because of the next bug).
Users expect to be able to navigate their cursor around freely as they can with any other text input.

UI Changes

Before

Screen.Recording.2026-03-10.at.19.39.17.mov

After

Screen.Recording.2026-03-10.at.19.40.18.mov

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

[!NOTE]

Fix cursor bugs and prompt sync logic in Plan mode composer

In ChatView.tsx, the effect syncing customAnswer into the composer now tracks the last-synced requestId and questionId, updating the editor only when the active question/request changes or when the server-provided text differs from the current editor content.
In ComposerPromptEditor.tsx, an isApplyingControlledUpdateRef flag prevents programmatic value/cursor updates from triggering onChange callbacks, breaking the feedback loop that caused cursor bugs.
Selection is now applied during controlled updates even when the editor is not focused, fixing cases where cursor position was lost after a server-driven update.

^{Macroscope summarized 621f5f0.}

coderabbitai · 2026-03-10T23:53:35Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3cef0396-04d8-45db-84f5-cbe7fed08253

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

…mptEditorHandle`

… prop-controlled updates

…tton press)

juliusmarminge · 2026-03-12T18:19:16Z

@macroscope-app review this

…lan mode (pingdotgg#867) Co-authored-by: Julius Marminge <julius0216@outlook.com>

* add Ymit24 to vouched list (pingdotgg#959) * fix: fix logo aligment regression on macOS (pingdotgg#960) * fix: Fix response duration for agent to no longer always be 1ms (pingdotgg#866) * fix: diff panel unclosable after retainSearchParams middleware (pingdotgg#937) * fix: improve business logic in prompt editor and fix cursor bugs in Plan mode (pingdotgg#867) Co-authored-by: Julius Marminge <julius0216@outlook.com> * feat: add selective file staging to commit dialog (pingdotgg#872) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(web): resolve preferred editor from available editors & introduce `useLocalStorage` helper (pingdotgg#662) Co-authored-by: Julius Marminge <julius0216@outlook.com> * style(web): reformata mockServiceWorker.js com prettier * style(chat): formatar imports no ChatView.logic --------- Co-authored-by: Noah Gregory <noah@wts.dev> Co-authored-by: Jono Kemball <Noojuno@users.noreply.github.com> Co-authored-by: eggfriedrice <eggfriedricew.g.o@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Guilherme Vieira <46866023+GuilhermeVieiraDev@users.noreply.github.com> Co-authored-by: Magnus Buvarp <magnus.buvarp@gmail.com>

github-actions bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Mar 10, 2026

This was referenced Mar 11, 2026

In the "Plan mode" text input cursor focus forced to the right #411

Closed

bug: text input on the GPT questions #909

Closed

nmggithub added 4 commits March 12, 2026 02:58

refactor: remove redunant focusAt function wrapping in `ComposerPro…

23378fd

…mptEditorHandle`

fix: skip firing the onChange handler in ComposerPromptEditor for…

2152312

… prop-controlled updates

fix: still set composer cursor when input is unfocused (e.g. after bu…

03a55d6

…tton press)

refactor: tighten up pending input sync behavior to fix cursor bugs

fe99740

nmggithub force-pushed the composer-fixes branch from a929143 to fe99740 Compare March 12, 2026 06:58

Merge branch 'main' into composer-fixes

621f5f0

juliusmarminge approved these changes Mar 12, 2026

View reviewed changes

juliusmarminge merged commit f63cda2 into pingdotgg:main Mar 12, 2026
8 of 9 checks passed

juliusmarminge added a commit to hobostay/t3code that referenced this pull request Mar 12, 2026

fix: improve business logic in prompt editor and fix cursor bugs in P…

f2202eb

…lan mode (pingdotgg#867) Co-authored-by: Julius Marminge <julius0216@outlook.com>

gabrielMalonso pushed a commit to gabrielMalonso/t3code that referenced this pull request Mar 12, 2026

fix: improve business logic in prompt editor and fix cursor bugs in P…

4b977a9

…lan mode (pingdotgg#867) Co-authored-by: Julius Marminge <julius0216@outlook.com>

gabrielMalonso mentioned this pull request Mar 12, 2026

cherry-pick: integrate 7 upstream commits with fork enhancements gabrielMalonso/t3code#12

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve business logic in prompt editor and fix cursor bugs in Plan mode#867

fix: improve business logic in prompt editor and fix cursor bugs in Plan mode#867
juliusmarminge merged 5 commits intopingdotgg:mainfrom
nmggithub:composer-fixes

nmggithub commented Mar 10, 2026 •

edited by macroscopeapp bot

Loading

Uh oh!

coderabbitai bot commented Mar 10, 2026 •

edited

Loading

Review skipped

Uh oh!

juliusmarminge commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nmggithub commented Mar 10, 2026 • edited by macroscopeapp bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

UI Changes

Before

After

Checklist

Fix cursor bugs and prompt sync logic in Plan mode composer

Uh oh!

coderabbitai bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

juliusmarminge commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nmggithub commented Mar 10, 2026 •

edited by macroscopeapp bot

Loading

coderabbitai bot commented Mar 10, 2026 •

edited

Loading